implemented & added tests for hash operations HSET, HKEYS, HGET, HDEL, HGETALL #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have to open a new PR only to add another commit, simply pushing the test commit to your branch would have updated the old PR. (This is also why it's generally preferred to make a branch on your fork first, and open a pull request from the branch to the original master. 😉) Thanks for the PR by the way. |
|
Thank you for the advice. |
popaaaandrei
changed the title
tanner0101
reviewed
Feb 7, 2019
There was a problem hiding this comment.
Hi @popaaaandrei, sorry for missing this PR. I'd be happy to merge this if we can resolve the conflicts.
|
@tanner0101 done; rebased again |
|
Hey @popaaaandrei, you just merged a pull request, have a coin! You now have 1 coins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more hash operations but these are the basic ones.
Also tried to document as much as possible.