Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with tail content-range headers #2840

Merged
merged 12 commits into from
Jun 5, 2022
Merged

Fix issue with tail content-range headers #2840

merged 12 commits into from
Jun 5, 2022

Conversation

BennyDeBock
Copy link
Member

@BennyDeBock BennyDeBock commented Jun 1, 2022

Adds testing for the different content-range options (start, within and tail)

Fix the bytecount calculation of the content-range headers

Add tests that should fail.

closes #2836

@BennyDeBock BennyDeBock requested a review from 0xTim June 1, 2022 08:00
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Adding review so GH reminds me when it's updated) - this looks great but we need to test edge cases more and ensure videos still play back etc if you could do a manual test as well)

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim
Copy link
Member

0xTim commented Jun 1, 2022

Will roll this is with a bunch of other PRs today

@BennyDeBock BennyDeBock merged commit a0fbe48 into vapor:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Range with tail sent is handled wrongly on media stream
2 participants