-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with tail content-range headers #2840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Adding review so GH reminds me when it's updated) - this looks great but we need to test edge cases more and ensure videos still play back etc if you could do a manual test as well)
Remove unused calculation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Will roll this is with a bunch of other PRs today |
Adds testing for the different content-range options (start, within and tail)
Fix the bytecount calculation of the content-range headers
Add tests that should fail.
closes #2836