Add Sendable conformances to WebsocketKit #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
commented
Apr 19, 2023
|
@Lukasa if you want to give this a once over to make sure I'm not doing anything stupid that would be great! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 85.78% 83.93% -1.86%
==========================================
Files 6 6
Lines 626 641 +15
==========================================
+ Hits 537 538 +1
- Misses 89 103 +14
|
gwynne
requested changes
Apr 20, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gwynne
requested changes
May 19, 2023
There was a problem hiding this comment.
LGTM at this point, with some caveats:
- With all the
@Sendableadditions, I wonder if we should require Swift 5.7. Reasoning: NIO wraps such additions in#if swift(>=5.7), despite@preconcurrencyhaving been added in 5.6; I don't know why this is. - Definitely wouldn't mind a quick eyeballing of this from @Lukasa.
- Need to deal with that deadlocking test.
|
Ok @gwynne I think we're finally good and I've fixed the race conditions in the tests |
gwynne
previously approved these changes
May 22, 2023
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
gwynne
approved these changes
May 24, 2023
|
These changes are now available in 2.10.0 |
gwynne
added a commit
that referenced
this pull request
May 25, 2023
Merged
0xTim
added a commit
that referenced
this pull request
May 25, 2023
0xTim
added a commit
that referenced
this pull request
May 25, 2023
* Add dev containers to gitignore * Revert "Revert "Add Sendable conformances to WebsocketKit (#131)" (#135)" This reverts commit 0b43ce5. * Add @preconcurrency annotations to work around unsafe users * More preconcurrency annotations * Add API breakage allowlist * Add missing preconcurrency annotations * Last missing annotations * Update allowlist --------- Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimum Swift version to 5.6 and add Sendable conformances where appropriate