Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use docker bake to build binaries #405

Merged
merged 10 commits into from
Nov 13, 2023

Conversation

nlevee
Copy link
Collaborator

@nlevee nlevee commented Nov 8, 2023

Fix #377

@nlevee nlevee force-pushed the feat/release-binaries branch 2 times, most recently from 82947c4 to 76b4bc2 Compare November 8, 2023 21:59
@nlevee nlevee force-pushed the feat/release-binaries branch 2 times, most recently from d78b11f to 8f7241d Compare November 8, 2023 22:32
@nlevee nlevee marked this pull request as draft November 8, 2023 22:37
@nlevee nlevee marked this pull request as ready for review November 8, 2023 23:21
@nlevee nlevee marked this pull request as draft November 9, 2023 08:28
@mckaygerhard
Copy link

Hi @nlevee may you enable squashig of the PR ? also release will only work in lasted linuxes and most of the non expert users will not understand the complexity of the workflow of a web service program

@nlevee nlevee marked this pull request as ready for review November 9, 2023 23:52
@nlevee
Copy link
Collaborator Author

nlevee commented Nov 9, 2023

Hi @nlevee may you enable squashig of the PR ? also release will only work in lasted linuxes and most of the non expert users will not understand the complexity of the workflow of a web service program

Hi,
Ho do I enable squashing ?

Build is now working on each tag prefixed by "v*". It create a release automatically.
I think It's more simple to find the binary in release page instead of action summary (for artifacts), don't you ?

@nlevee nlevee self-assigned this Nov 10, 2023
@nlevee nlevee added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 10, 2023
@nlevee nlevee requested review from varbhat and removed request for mckaygerhard November 10, 2023 15:45
@varbhat
Copy link
Owner

varbhat commented Nov 10, 2023

Hey, I had already valuated goreleaser before but for some reasons didn't use it(some features were under pro license, it did too much instead of doing minimum required things, etc.).More than these, it was difficult to integrate with musl builder that i was using. So i went no-tools route.

Have you looked into https://github.com/arp242/gogo-release ? It was better imo.

@nlevee nlevee changed the title feat(ci): use goreleaser to build binaries feat(ci): use docker bake to build binaries Nov 10, 2023
@nlevee
Copy link
Collaborator Author

nlevee commented Nov 10, 2023

Hey, I had already valuated goreleaser before but for some reasons didn't use it(some features were under pro license, it did too much instead of doing minimum required things, etc.).More than these, it was difficult to integrate with musl builder that i was using. So i went no-tools route.

Have you looked into https://github.com/arp242/gogo-release ? It was better imo.

I totaly agree, I forgot to change the PR name, i don't use goreleaser anymore for the same reason you had before. I use docker because it work well and permit to build and publish with a single solution.

@nlevee
Copy link
Collaborator Author

nlevee commented Nov 13, 2023

@varbhat do you have review on this PR ?

@varbhat varbhat merged commit 172f963 into varbhat:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plan on providing the binaries to us directly via GitHub?
3 participants