Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #10

Closed
slhck opened this issue Feb 16, 2019 · 14 comments
Closed

Setup CI #10

slhck opened this issue Feb 16, 2019 · 14 comments
Labels
maintainer-feedback Feedback requested from maintainers

Comments

@slhck
Copy link
Collaborator

slhck commented Feb 16, 2019

We should use Travis to make CI automated builds of the formula for:

  • macOS 10.12–10.14
  • Linux (e.g., Ubuntu LTS)

A good starting point for a .travis.yml could be this one: https://github.com/denji/homebrew-nginx/blob/master/.travis.yml

Some other options are visible here: https://github.com/petere/homebrew-postgresql/blob/master/.travis.yml

Not a big expert when it comes to Travis, so I'll have to do some offline testing before.

@slhck slhck added the maintainer-feedback Feedback requested from maintainers label Feb 16, 2019
@retokromer
Copy link
Collaborator

retokromer commented Feb 16, 2019

(I personally do not like Travis, because the noise produced is much bigger than the benefit. Yet if one implements it, then I’m in favour. I’m just not willing to do it myself.)

@slhck
Copy link
Collaborator Author

slhck commented Apr 12, 2019

This Dockerfile would install the formula (with options, if necessary):

FROM ubuntu:bionic
ARG DEBIAN_FRONTEND=noninteractive

RUN apt-get update \
    && apt-get install -y --no-install-recommends ca-certificates curl file g++ git locales make uuid-runtime python3-pip \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/* \
    && localedef -i en_US -f UTF-8 en_US.UTF-8 \
    && useradd -m -s /bin/bash linuxbrew \
    && echo 'linuxbrew ALL=(ALL) NOPASSWD:ALL' >>/etc/sudoers

USER linuxbrew
WORKDIR /home/linuxbrew
ENV PATH=/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:$PATH \
    SHELL=/bin/bash

RUN git clone https://github.com/Linuxbrew/brew.git /home/linuxbrew/.linuxbrew/Homebrew \
    && mkdir /home/linuxbrew/.linuxbrew/bin \
    && ln -s ../Homebrew/bin/brew /home/linuxbrew/.linuxbrew/bin/ \
    && brew config

RUN brew tap varenc/ffmpeg \
    && brew install varenc/ffmpeg/ffmpeg

We could probably use this and Travis to build a container for testing. Will have to look further…

@slhck
Copy link
Collaborator Author

slhck commented Apr 24, 2019

It seems I cannot even set up CI since I don't own this repository.

@varenc and others, I think we should migrate this repository to its own independent organization in the mid-term. This would allow proper permission handling, and also allow maintainers to change over time.

@retokromer
Copy link
Collaborator

We have chosen the current repository, because it was not possible to publish the formula inside FFmpeg…

@slhck
Copy link
Collaborator Author

slhck commented Apr 24, 2019

By independent organization I also meant one independent from FFmpeg, since I guess that ship has sailed. (Maybe they'd reconsider it, but I was thinking of "Homebrew-ffmpeg" or similar.)

@retokromer
Copy link
Collaborator

I was thinking of "Homebrew-ffmpeg" or similar.

OK

@slhck
Copy link
Collaborator Author

slhck commented May 30, 2019

I pinged Chris to have a look at this and provide his input. I don't want to upset anyone in FFmpeg with choosing a name that implies affiliation. I guess we should add an explicit note about that.

@retokromer
Copy link
Collaborator

I don't want to upset anyone in FFmpeg

Mission: Impossible ;-)

@retokromer
Copy link
Collaborator

The formula could also be moved to AMIA Open Source GitHub repository which already hosts ffmprovisr, vrecord and many other tools and ressources.

AMIA = Association of Moving Image Archivists

@slhck
Copy link
Collaborator Author

slhck commented Jul 4, 2019

Thanks for the offer/suggestion. Personally, I'd prefer a new organization. I have not heard from @varenc for months now, and I am quite unhappy about not having control over this repo, so I suggest that in the worst case – e.g. in a month from now – we create a fork and update the guides on Trac and perhaps some other pages from where the formula is linked.

@retokromer
Copy link
Collaborator

in a month from now

@slhck Any news? This formula is used with different options (search e.g. varenc).

@slhck
Copy link
Collaborator Author

slhck commented Sep 1, 2019

No news so far. I did send a follow-up end of June. I'm ready to move forward.

What is your opinion on creating an organization homebrew-ffmpeg with the corresponding repository name homebrew-ffmpeg, with us as maintainers? I know this is a little verbose when writing out the command to install the 3rd party formula, but people are most likely going to copy-paste it anyway.

As for migrating, we should then change the links here.

To be safe, let's just include a visible note that the organization/repo is not affiliated with the project FFmpeg.

@retokromer
Copy link
Collaborator

I am fine with homebrew-ffmpeg/homebrew-ffmpeg witch in practice can be written as homebrew-ffmpeg/ffmpeg when used (the second homebrew- is not mandatory).

To be safe, let's just include a visible note that the organization/repo is not affiliated with the project FFmpeg.

+1

@slhck
Copy link
Collaborator Author

slhck commented Sep 2, 2019

Both done, see https://github.com/homebrew-ffmpeg/homebrew-ffmpeg. You have been given owner rights.

@slhck slhck closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-feedback Feedback requested from maintainers
Projects
None yet
Development

No branches or pull requests

2 participants