Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter scores from extra anno #324

Closed
wants to merge 11 commits into from

Conversation

snesic
Copy link
Contributor

@snesic snesic commented Feb 2, 2022

Here is the part that adds extra anno scores to the filtered variants.

Closes #242

@holtgrewe holtgrewe self-requested a review February 2, 2022 08:30
@holtgrewe holtgrewe marked this pull request as draft February 2, 2022 08:30
@holtgrewe holtgrewe marked this pull request as ready for review February 2, 2022 08:30
Copy link
Collaborator

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • rebase to current upstream main branch
  • ensure to run make black for automatic code formatting
  • add selenium UI tests at least to
    • check that no value is displayed in the beginning
    • check that adding a column works
    • check that hiding the column works
    • check that sorting by column works

@holtgrewe
Copy link
Collaborator

Also, please

  • add entry to HISTORY.rst

@holtgrewe holtgrewe added this to the athenea-1.1.0 (RC) milestone Feb 7, 2022
@holtgrewe
Copy link
Collaborator

Closing in favour of #358.

@holtgrewe holtgrewe closed this Mar 4, 2022
@holtgrewe holtgrewe added the duplicate This issue or pull request already exists label Mar 4, 2022
@snesic snesic deleted the filter_scores_from_extra-anno branch March 13, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add REVEL Score
3 participants