Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to export/import highlighters configuration #173

Closed
federico-piazza opened this issue Jan 29, 2020 · 7 comments
Closed

Ability to export/import highlighters configuration #173

federico-piazza opened this issue Jan 29, 2020 · 7 comments

Comments

@federico-piazza
Copy link

Highlighters are possibly the most important feature of Klogg. It would be great to have a feature to export the highlighters configuration and import it as well.

This way we can share with other team members the different configuration. Even better we can save different log profiles so we don't mix highlighters for different files and also be able to export/import them.

@gin-ahirsch
Copy link

gin-ahirsch commented Jan 30, 2020

I implemented this for glogg, as documented in nickbnf#234. The code is linked in the issue.
I held off porting this change to klogg since there were some alternative suggestions from coworkers on how to improve its UI by integrating (some) of this functionality directly in the main-window.

The project got set on the back-burner for a while, but we're planning on having a meeting next week or the week after specifically to discuss our internal extensions to klogg, after which I can post the results of that internal discussion and maybe I can work on implementing that, depending on how that'll be prioritized by my PM.
Regardless, some of my previous code may be adaptable to klogg.

@variar
Copy link
Owner

variar commented Feb 12, 2020

I've looked at code from nickbnf#234 and it can be used as a basis for the this feature in klogg.

However, this is big feature that may futher delay next stable release (now scheduled for February 2020 due to personal reasons).

@gin-ahirsch
Copy link

Hey, sorry we didn't get around to the meeting in our office due to sickness and I've been busy with different products since. I'm not sure when I can get back to work on this feature. I'll surely keep it in mind and give notice once this is back on our map though!

@variar variar self-assigned this May 9, 2020
@variar variar added this to the 2020.08 milestone May 9, 2020
@fflatorre
Copy link

+1

@variar
Copy link
Owner

variar commented Sep 13, 2020

Highlighters UI has been reworked to allow several highlighting groups (#190). Can be tested in builds >= 20.9.0.658. Now export/import should be relatively easy to do

@variar variar added status: ready for testing resolved but needs testing and removed status: in progress labels Sep 13, 2020
@variar
Copy link
Owner

variar commented Sep 13, 2020

This proved to be easier that initially estimated. Should work in builds 20.9.0.659. Could be improved to allow exporting only part of configuration, but that can be done as separate issue.

@variar
Copy link
Owner

variar commented Oct 2, 2020

Looks ok in my tests. Closing for now. Feel free to reopen if this issue reproduces in builds > 20.10.0.746

@variar variar closed this as completed Oct 2, 2020
@variar variar added status: done and removed status: ready for testing resolved but needs testing labels Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants