Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Hard to view search result on Mac #612

Closed
czlitony opened this issue Jun 23, 2023 · 5 comments
Closed

[Bug]Hard to view search result on Mac #612

czlitony opened this issue Jun 23, 2023 · 5 comments
Assignees
Milestone

Comments

@czlitony
Copy link

When scrolling up the view result, it's weird that a white space will appear. The search view height is small on Mac, so I have to scroll down every time to view the search result.
image

If I don't scroll down the search view, and keep the whitespace there, then I can't select a line, when clicking a line, then an upper line will be selected.
image

@roman-szul-red
Copy link

The same on Linux (Ubuntu 20, 22)

@variar variar self-assigned this Jun 23, 2023
@variar variar added this to the 2023.next milestone Jun 23, 2023
@variar
Copy link
Owner

variar commented Jun 23, 2023

when clicking a line, then an upper line will be selected.

In recent builds most likely caused by changes for word wrap (#99)

@variar
Copy link
Owner

variar commented Jun 23, 2023

Couple of comments:

The search view height is small on Mac

It should be possible to resize top and bottom panels by dragging the slider between them

When scrolling up the view result, it's weird that a white space will appear

That striped area indicates, that currently follow file mode is enabled. It this case klogg watches for file changes and updates the views, much like tail -f command. In this mode scrolling is pinned to the bottom of the view because there new lines will appear. Scrolling up has some 'resistance' to avoid disabling follow file mode by accident. By default scrolling past the end of file enables 'follow file' mode. That can be disabled in stettings.

@czlitony
Copy link
Author

Thank you, the striped area doesn't show up when the follow file is disabled.
image

Not sure if we can make the striped area take up only one line height? Then it will not take much space in the search result area.

@variar
Copy link
Owner

variar commented Jun 23, 2023

It should take 1 line. Looks like the height is calculated wrongly

variar pushed a commit that referenced this issue Jul 24, 2023
Co-authored-by: chengzhl <chengzhl@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants