Fix #89 #106
Merged
Fix #89 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further, introduce a maroon arrow for marked and matched lines.
The line types did not take inactive visibility modes into account, but we need correct / complete flags since display behavior relies on their differentiation now.
|
The Travis CI failure is due to an networking error. |
|
Thanks! I've changed marked match color to be little lighter, so it is more noticable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (and implements the change proposed in) #89.
I found the marron (dark red) arrow stylistically more pleasing than a violet one for lines that are simultaneously marked and matched.
One more thing that needed changing, which did not become apparent in #89, is adding "missing" flags on the
filteredItemsCache_when a visibility-mode is inactive (commit 9c3e926).This issue manifested, for example, in just the regular red circle showing in the filtered view when only viewing matches (not "MarksAndMatches") and making a new search. Even if the line is marked, which should display a maroon arrow, it displayed a red circle, since
insertNewMatches()simply setsLineTypeFlag::Match.