Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): support indeterminate status and slot #1159

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Aug 23, 2023

Checklist

List of tasks you have already done and plan to do.

  • add indeterminate status
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 9:47am

@vercel
Copy link

vercel bot commented Aug 23, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1159 (674d949) into dev (56cdff8) will increase coverage by 0.00%.
Report is 8 commits behind head on dev.
The diff coverage is 95.00%.

❗ Current head 674d949 differs from pull request most recent head c5fb262. Consider uploading reports for the commit c5fb262 to get more accurate results

@@           Coverage Diff           @@
##              dev    #1159   +/-   ##
=======================================
  Coverage   95.70%   95.71%           
=======================================
  Files         337      337           
  Lines       22098    22081   -17     
  Branches     2175     2162   -13     
=======================================
- Hits        21149    21134   -15     
+ Misses        898      896    -2     
  Partials       51       51           
Files Changed Coverage Δ
packages/varlet-ui/src/checkbox/Checkbox.vue 96.47% <93.75%> (+0.17%) ⬆️
packages/varlet-ui/src/checkbox/props.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@chouchouji
Copy link
Member Author

chouchouji commented Aug 24, 2023

How about adding an indeterminate slot to provide more flexibility?
like this
image
@haoziqaq

@chouchouji chouchouji changed the title feat(checkbox): add indeterminate status feat(checkbox): support indeterminate status & slot Aug 24, 2023
@chouchouji chouchouji changed the title feat(checkbox): support indeterminate status & slot feat(checkbox): support indeterminate status and slot Aug 24, 2023
@haoziqaq haoziqaq merged commit 41cd712 into varletjs:dev Aug 24, 2023
3 of 4 checks passed
@chouchouji chouchouji deleted the feat-checkbox branch August 24, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants