Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox-group): support options #1624

Merged
merged 13 commits into from
May 24, 2024
Merged

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented May 18, 2024

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:06am

Copy link

vercel bot commented May 18, 2024

@chouchouji is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.75%. Comparing base (039edaf) to head (90e9528).

Current head 90e9528 differs from pull request most recent head 80aa84a

Please upload reports for the commit 80aa84a to get more accurate results.

Files Patch % Lines
...rlet-ui/src/checkbox-group/CheckboxGroupOption.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1624      +/-   ##
==========================================
- Coverage   92.76%   92.75%   -0.01%     
==========================================
  Files         306      307       +1     
  Lines        7184     7194      +10     
  Branches     1788     1793       +5     
==========================================
+ Hits         6664     6673       +9     
- Misses        453      454       +1     
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/varlet-ui/src/checkbox-group/CheckboxGroup.vue Outdated Show resolved Hide resolved
packages/varlet-ui/src/checkbox-group/CheckboxGroup.vue Outdated Show resolved Hide resolved
packages/varlet-ui/types/checkboxGroup.d.ts Outdated Show resolved Hide resolved
packages/varlet-ui/types/checkboxGroup.d.ts Outdated Show resolved Hide resolved
@haoziqaq haoziqaq merged commit e345c0a into varletjs:dev May 24, 2024
3 of 4 checks passed
@chouchouji chouchouji deleted the feat-checkbox branch May 27, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants