Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app-bar, bottom-navigation): optimize code #1667

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

chouchouji
Copy link
Member

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 10:22am

Copy link

vercel bot commented Jun 9, 2024

@chouchouji is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (2fdc79f) to head (a8e65d1).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1667   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         308      308           
  Lines        7254     7254           
  Branches     1807     1807           
=======================================
  Hits         6729     6729           
  Misses        458      458           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoziqaq haoziqaq merged commit 7335f09 into varletjs:dev Jun 9, 2024
5 of 6 checks passed
@haoziqaq haoziqaq deleted the refactor-ui branch June 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants