Skip to content

Commit

Permalink
Try to stabilize this test
Browse files Browse the repository at this point in the history
I ignored this for ages, but now it really bothers me: This test had
quite a high failure rate on systems I control. And actually I do not
quite understand why the fix works, but it does survive -j100 -n1000

Additional input welcome
  • Loading branch information
nigoroll committed Apr 23, 2019
1 parent 4bbf6df commit 3e6e584
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions bin/varnishtest/tests/r01490.vtc
Expand Up @@ -6,28 +6,28 @@ server s1 {
varnish v1 \
-arg "-p debug=+syncvsl" \
-arg "-p vsl_mask=+WorkThread" \
-arg "-p thread_pool_min=2" \
-arg "-p thread_pool_max=3" \
-arg "-p thread_pool_min=3" \
-arg "-p thread_pool_max=4" \
-arg "-p thread_pools=1" \
-arg "-p thread_pool_timeout=10" \
-vcl+backend {}
varnish v1 -start

delay 2

varnish v1 -expect threads == 2
varnish v1 -expect threads == 3

logexpect l1 -v v1 -g raw {
expect * 0 WorkThread {^\S+ start$}
expect * 0 WorkThread {^\S+ end$}
} -start

varnish v1 -cliok "param.set thread_pool_min 3"
varnish v1 -cliok "param.set thread_pool_min 4"

# Have to wait longer than thread_pool_timeout
delay 11

varnish v1 -expect threads == 3
varnish v1 -expect threads == 4

varnish v1 -cliok "param.set thread_pool_min 2"
varnish v1 -cliok "param.set thread_pool_max 2"
Expand Down

0 comments on commit 3e6e584

Please sign in to comment.