Skip to content

Commit

Permalink
param: Restore old default h2_max_header_list_size
Browse files Browse the repository at this point in the history
Except that the old default value replaces the maximum one. Aligning
with the literal maximum value for the underlying HTTP/2 setting breaks
32bit builds because the byte tweaks take a detour via ssize_t. When it
casts to uintmax_t the MSB is propagated all the way, triggering the
following error at build time:

> 4294967295b is too large for this architecture.

Instead of fighting a tweak that is clearly wrong, grant h2 clients a
maximum of 2GB of uncompressed headers (instead of 4GB) that will never
happen, because h2 is overall much wronger.
  • Loading branch information
Dridi committed Apr 4, 2024
1 parent 758dad0 commit 65a42d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/tbl/params.h
Expand Up @@ -1288,7 +1288,7 @@ PARAM_SIMPLE(
/* name */ h2_max_header_list_size,
/* type */ bytes_u,
/* min */ "0b",
/* max */ "4294967295b",
/* max */ "2147483647b", /* NB: not the RFC maximum */
/* def */ "0b",
/* units */ "bytes",
/* descr */
Expand Down

0 comments on commit 65a42d1

Please sign in to comment.