Skip to content

Commit

Permalink
For BackendClose, also log the short tag as with SessClose
Browse files Browse the repository at this point in the history
this is for consistency, to simplify parsing and to reduce the amount of
data logged with VSL.

Motivated by #4042
  • Loading branch information
nigoroll committed Mar 1, 2024
1 parent d92ca50 commit a73e6a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bin/varnishd/cache/cache_backend.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ vbe_dir_finish(VRT_CTX, VCL_BACKEND d)
bo->htc->priv = NULL;
if (bo->htc->doclose != SC_NULL || bp->proxy_header != 0) {
VSLb(bo->vsl, SLT_BackendClose, "%d %s close %s", *PFD_Fd(pfd),
VRT_BACKEND_string(d), bo->htc->doclose->desc);
VRT_BACKEND_string(d), bo->htc->doclose->name);
VCP_Close(&pfd);
AZ(pfd);
Lck_Lock(bp->director->mtx);
Expand Down
2 changes: 1 addition & 1 deletion include/tbl/vsl_tags.h
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ SLTM(BackendClose, 0, "Backend connection closed",
"The format is::\n\n"
"\t%d %s %s [ %s ]\n"
"\t| | | |\n"
"\t| | | +- Optional reason\n"
"\t| | | +- Optional reason, see SessClose for explanation\n"
"\t| | +------ \"close\" or \"recycle\"\n"
"\t| +--------- Backend display name\n"
"\t+------------ Connection file descriptor\n"
Expand Down

0 comments on commit a73e6a5

Please sign in to comment.