New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one minute delay on return (pipe) and a POST-Request #1806
Comments
I looked into this. The issue seems to be that for return (pipe) we don't pass the request body. For pipe this is deferred until we do V1P_Process. This is fine for piped connections where we use a fresh backend connection, but when we get a recycled connection (state == STOLEN) we do VBT_Wait and go on the waiter first. Thus the backend receives a request indicating a req body and waits around for that. At the same time the vbc is on the waiter expecting data from the backend, and we end up in a deadlock situation until timeout. A fix could be to always force a fresh backend connection for piped requests (thereby avoiding the waiter), but there might be a more elegant solution? |
+1 |
Related to #1772. |
Fixes a bug where we went on the waiter prior to passing the request body. The VBT_Wait call is now handled in vbe_dir_finish. Test case by thomaslc Fixes: varnishcache#1806
Fixes a bug where we went on the waiter prior to passing the request body. The VBT_Wait call is now handled in vbe_dir_finish. Test case by thomaslc Fixes: varnishcache#1806
Fixes a bug where we wait for an event to fire on the backend socket prior to passing the request body. The VBT_Wait call is now handled in vbe_dir_finish. Test case by thomaslc Fixes: varnishcache#1806
Fixes a bug where we wait for an event to fire on the backend socket prior to passing the request body. The VBT_Wait call is now handled in vbe_dir_finish. Test case by thomaslc Fixes: #1806
Current version on Debian Jessie 4.1.2 (Mar 4th) still has this bug, which was fixed on March 14th. Any idea when this fix is going to reach Debian Jessie? Thank you very much. |
Strictly speaking, since it is jessie, our official packages covers it and will most likely be out a day or two after the release. |
@lkarsten thank you very much |
backport review: commited to 4.1 head, needs 4.0 review. |
@lkarsten When it will be available the fix in Varnish 4.1 for Ubuntu? |
Hello. Any idea when is this comming to ubuntu? I have a couple of ubuntu 16 servers with migrated sites and until this is fixed I have to change all pipe to pass in the vcls in order for posts to work quickly, but this introduces some other problems. Thanks |
@cherouvim Ubuntu packaging for Xenial is handled by the maintainers of the ubuntu package maintainers (http://packages.ubuntu.com/xenial/varnish). @ssm might be able to guesstimate something, but due to the nature of the process it's not easy. |
Old ticket imported from Trac
See archived copy here: https://varnish-cache.org/trac/ticket/1806
The text was updated successfully, but these errors were encountered: