Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Sometimes the VSL thread in varnishtest simply doesn't get hold of anything.
I have tried to postpone startup of the VSL thread until I am sure there is something in the VSL, but it still happens.
To provoke the bug add this patch:
Create this VTC:
Fix a stupid misstake where the segment counter in the VSL segment was set just before the entire struct was cleared during initialization. This didn't cause problems in the common case because it would be set correctly on the very first log line produced. But it did open a race where an unfortunate early log client would assume it was lagging indefinetely behind varnishd on the log reading and report overflow error. This was most commonly experienced with varnishtest. Fixes: #2241