Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for std.collect might be bad #2292

Closed
simonvik opened this issue Mar 30, 2017 · 1 comment
Closed

Documentation for std.collect might be bad #2292

simonvik opened this issue Mar 30, 2017 · 1 comment

Comments

@simonvik
Copy link
Contributor

https://varnish-cache.org/docs/trunk/reference/vmod_std.generated.html#func-collect

Contains an example that says:

Example
std.collect(req.http.cookie);

Multiple cookie headers should not be sent over HTTP/1.1 and if they were then they should be joined by "; " and not "," as the module does.

h2-clients might send multiple cookie headers and that's reported in : #2291

@Dridi Dridi self-assigned this Mar 30, 2017
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 30, 2017
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 30, 2017
The default separator is now ", " to maintain the "pretty collapsing" of
the headers without risking an extra space with the "; " separator for
cookies.

Refs varnishcache#2291
Refs varnishcache#2292
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 30, 2017
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 31, 2017
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 31, 2017
The default separator is now ", " to maintain the "pretty collapsing" of
the headers without risking an extra space with the "; " separator for
cookies.

Refs varnishcache#2291
Refs varnishcache#2292
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 31, 2017
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 31, 2017
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 31, 2017
The default separator is now ", " to maintain the "pretty collapsing" of
the headers without risking an extra space with the "; " separator for
cookies.

Refs varnishcache#2291
Refs varnishcache#2292
Dridi added a commit to Dridi/varnish-cache that referenced this issue Mar 31, 2017
@Dridi Dridi closed this as completed in 58b2d30 Mar 31, 2017
Dridi added a commit that referenced this issue Mar 31, 2017
The default separator is now ", " to maintain the "pretty collapsing" of
the headers without risking an extra space with the "; " separator for
cookies.

Refs #2291
Refs #2292
Dridi added a commit that referenced this issue Mar 31, 2017
@hermunn
Copy link
Member

hermunn commented Apr 6, 2017

Backport review: I do not think there is a need for this in 4.1, so we will keep it Varnish 5 only unless I hear strong protests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants