New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ban lurker skips objects #3007
Comments
rezan
pushed a commit
to rezan/varnish-cache
that referenced
this issue
Jul 11, 2019
93d8050 made execution of ban_lurker_test_ban() conditional on bd != b, which effectively caused objects hanging off bans below request bans to not get tested against relevant bans. Because object bans (from the obans list) are being marked completed, the objects which were skipped would also be missed to get evaluated against the relevant bans at lookup time unless they were evaluated in request context. So, in effect, we would simply miss to test bans. Fixes varnishcache#3007 Maybe related to varnishcache#3006
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this issue
Oct 2, 2019
93d8050 made execution of ban_lurker_test_ban() conditional on bd != b, which effectively caused objects hanging off bans below request bans to not get tested against relevant bans. Because object bans (from the obans list) are being marked completed, the objects which were skipped would also be missed to get evaluated against the relevant bans at lookup time unless they were evaluated in request context. So, in effect, we would simply miss to test bans. Fixes varnishcache#3007 Maybe related to varnishcache#3006
hermunn
pushed a commit
to hermunn/varnish-cache
that referenced
this issue
Nov 3, 2020
93d8050 made execution of ban_lurker_test_ban() conditional on bd != b, which effectively caused objects hanging off bans below request bans to not get tested against relevant bans. Because object bans (from the obans list) are being marked completed, the objects which were skipped would also be missed to get evaluated against the relevant bans at lookup time unless they were evaluated in request context. So, in effect, we would simply miss to test bans. Fixes varnishcache#3007 Maybe related to varnishcache#3006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pro-forma bug for fix ready to go in:
93d8050 made execution of
ban_lurker_test_ban()
conditional onbd != b
, which effectively caused objects hanging off bans below request bans to not get tested against relevant bans.Because object bans (from the obans list) are being marked completed, the objects which were skipped would also be missed to get evaluated against the relevant bans at lookup time unless they were evaluated in request context. So, in effect, we would simply miss to test bans.
Demo:
The text was updated successfully, but these errors were encountered: