Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: is session close reason RX_TIMEOUT an error? #3208

Closed
nigoroll opened this issue Feb 4, 2020 · 1 comment
Closed

RFC: is session close reason RX_TIMEOUT an error? #3208

nigoroll opened this issue Feb 4, 2020 · 1 comment
Assignees
@nigoroll

Comments

@nigoroll
Copy link
Member

nigoroll commented Feb 4, 2020

varnish-cache/include/tbl/sess_close.h

Line 42 in f75bce1

SESS_CLOSE(RX_TIMEOUT, rx_timeout, 1, "Receive timeout")

we account RX_TIMEOUT as an error, so it gets accounted towards sess_closed_err

This might not be appropriate in particular for timeouts waiting for another request on http/1.1 keepalive connections.

questions:

  • do we want to change RX_TIMEOUT to not signify an error in general?
  • Alternatively, do we want to introduce another session close reason for "timeout waiting for another keepalive request"?
@nigoroll
Copy link
Member Author

bugwash: Add RX_CLOSE_IDLE close reason

@nigoroll nigoroll self-assigned this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nigoroll nigoroll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsdphk @nigoroll