std.ip: Always provide some form of fallback #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be a |
|
We could. In the scenario I got where the nested |
nigoroll
approved these changes
Nov 29, 2021
Otherwise valid code can panic on workspace exhaustion:
std.ip(req.http.X-Real-IP, std.ip(req.http.X-Client-IP, client.ip))
If the nested std.ip() call runs out of workspace, it will return a null
ip instead of the fallback, and since the outer std.ip() call is getting
a fallback argument, it will panic upon checking the suckaddr sanity.
Refs a3b26d0
dridi
force-pushed
the
std_ip_null_fallback
branch
from
6eb6699
to
5e497e6
Compare
|
I will submit a patch for the 6.0 branch too. |
dridi
added a commit
to dridi/varnish-cache
that referenced
this pull request
Nov 29, 2021
Otherwise valid code can panic on workspace exhaustion:
std.ip(req.http.X-Real-IP, std.ip(req.http.X-Client-IP, client.ip))
If the nested std.ip() call runs out of workspace, it will return a null
ip instead of the fallback, and the outer std.ip() call will panic upon
checking the suckaddr sanity.
Refs varnishcache#3746
dridi
added a commit
that referenced
this pull request
Nov 30, 2021
Otherwise valid code can panic on workspace exhaustion:
std.ip(req.http.X-Real-IP, std.ip(req.http.X-Client-IP, client.ip))
If the nested std.ip() call runs out of workspace, it will return a null
ip instead of the fallback, and the outer std.ip() call will panic upon
checking the suckaddr sanity.
Refs #3746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise valid code can panic on workspace exhaustion:
If the nested std.ip() call runs out of workspace, it will return a null
ip instead of the fallback, and since the outer std.ip() call is getting
a fallback argument, it will panic upon checking the suckaddr sanity.
Refs a3b26d0