move logic of VDI_Resolve() to VRT as VRT_DirectorResolve() #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
81fa673
to
ba5ee1b
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
f78eea3
to
4683e30
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
4 times, most recently
from
0460391
to
3b17f4e
Compare
|
FTR, I had accidentally pushed a bad commit in the meantime, now force-pushed the branch as it should be |
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
from
3b17f4e
to
0b2a4c8
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
3 times, most recently
from
a74b392
to
30a5a1f
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
from
30a5a1f
to
167dd32
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
3c91cb3
to
1a140c7
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
e533964
to
e0999d0
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
9e66561
to
d31d6ca
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
49c5da5
to
575577a
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
2 times, most recently
from
81e75e9
to
c6a4ab9
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
3 times, most recently
from
678f122
to
d4370af
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
from
d4370af
to
5418cec
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
from
5418cec
to
d3326d4
Compare
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
3 times, most recently
from
7909d35
to
cc481f3
Compare
The use case is eager resolution of directors in vmods, for example to determine if a director would resolve to a particular backend. The functionality is identical to VDI_Resolve(), except that no state in the busyobj is modified. VDI_Resolve() remains for error handling for calls from VDI_GetHdr() and VDI_Http1Pipe()
@Dridi rightly pointed out that, in the for loop condition, we accessed d->vdir->methods before asserting that d->vdir is non-NULL. Simplify and clean up for clarity. This code was basically just copied from existing code, so the issue addressed here exited before the previous change to introduce VRT_DirectorResolve.
nigoroll
force-pushed
the
VRT_DirectorResolve
branch
from
cc481f3
to
1b5e89e
Compare
bsdphk
added a commit
to bsdphk/varnish-cache
that referenced
this pull request
May 11, 2020
This is an alternative implementation of varnishcache#2680
|
Please see #3311 for an alternative implementation using type-specific methods. |
nigoroll
pushed a commit
that referenced
this pull request
May 13, 2020
This is an alternative implementation of #2680
|
merged #3311 instead |
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
May 13, 2020
recover a minor improvement from varnishcache#2680: This commit is to emit slightly different error messages to differentiate between the cases "no backend set in vcl" and "none returned from the director". Includes minor polishing Ref varnishcache#2860 varnishcache#3311
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
May 14, 2020
recover a minor improvement from varnishcache#2680: This commit is to emit slightly different error messages to differentiate between the cases "no backend set in vcl" and "none returned from the director". Includes minor polishing Ref varnishcache#2860 varnishcache#3311
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
May 19, 2020
recover a minor improvement from varnishcache#2680: This commit is to emit slightly different error messages to differentiate between the cases "no backend set in vcl" and "none returned from the director". Includes minor polishing Ref varnishcache#2860 varnishcache#3311
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
May 24, 2020
recover a minor improvement from varnishcache#2680: This commit is to emit slightly different error messages to differentiate between the cases "no backend set in vcl" and "none returned from the director". Includes minor polishing Ref varnishcache#2860 varnishcache#3311
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
Jun 10, 2020
recover a minor improvement from varnishcache#2680: This commit is to emit slightly different error messages to differentiate between the cases "no backend set in vcl" and "none returned from the director". Includes minor polishing Ref varnishcache#2860 varnishcache#3311
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
Jun 23, 2020
recover a minor improvement from varnishcache#2680: This commit is to emit slightly different error messages to differentiate between the cases "no backend set in vcl" and "none returned from the director". Includes minor polishing Ref varnishcache#2860 varnishcache#3311
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
Jun 23, 2020
Ref varnishcache#3315 (comment) OKed by phk on irc. VRT_DirectorResolve() was the name originally proposed in varnishcache#2680, which was renamed in varnishcache#3311 and accepted by me to get ahead. Not that Dridi prefers the original name and phk goes along, we change it back before the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VDI_Resolve() remains for error handling for calls from VDI_GetHdr() and VDI_Http1Pipe()