Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h2: Add a sess_close reason to h2 connection errors #3507

Merged
merged 2 commits into from Feb 10, 2021

Conversation

Dridi
Copy link
Member

@Dridi Dridi commented Jan 25, 2021

And use that for logging purposes when a successfully opened h2 session
ends. RX_JUNK is still the default session close reason when existing
reasons aren't accurate enough.

Fixes #3393

In the same fashion as include/tbl/params.h for legibility.
And use that for logging purposes when a successfully opened h2 session
ends. RX_JUNK is still the default session close reason when existing
reasons aren't accurate enough.

Fixes varnishcache#3393
Copy link
Member

@daghf daghf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nigoroll nigoroll requested a review from bsdphk February 10, 2021 13:17
@nigoroll nigoroll merged commit 5c1d082 into varnishcache:master Feb 10, 2021
@Dridi Dridi deleted the h2_sess_close branch September 20, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper h2 session close reason
3 participants