Deal with backends that don't close connections #3886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dridi
reviewed
Jan 16, 2023
walid-git
force-pushed
the
probe_expect_close
branch
from
139cdc1
to
f55d4ca
Compare
|
Do I read the patch correctly, that it still waits for the timeout to expire to accept the backend response? |
|
This is why I requested a warning in the documentation. It's much simpler to implement "expect_close=false" as a last chance after timeout. |
walid-git
force-pushed
the
probe_expect_close
branch
from
f55d4ca
to
deb4d4e
Compare
Dridi
requested changes
Jan 30, 2023
walid-git
force-pushed
the
probe_expect_close
branch
from
241c32a
to
c743846
Compare
It is already called from VCC_SymbolGet
walid-git
force-pushed
the
probe_expect_close
branch
from
029147a
to
11faf65
Compare
|
Reviewed and merged as 908c9b8...6f50b7c with @walid-git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "expect_close" parameter to probe to deal with backends that are considered sick because they don't close the TCP connection after sending the response.
The new parameter accepts the value true or false, and defaults to true for backward compatibility.