Call VDP_Close() for all cases and revert regression #4068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1 of the fix for varnishcache#4067
This reverts the code change from commit 6d423aa, keeps the test case and adds a VDP_Close() for the case that the transport deliver function is not called. Part 2 of the fix for varnishcache#4067 Conflicts: bin/varnishd/cache/cache_req_fsm.c
|
merged as of bb3d027 but it seems there is an issue with gh noticing the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues described in #4067 :
We add missing
VDP_Close()calls to the deliver functions of esi and http1, revert a wrong addition of aVDP_Close()call, add one at the right place and add aVDP_Fini()function with an assertion to ensure all cases are taken care of.