Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent locking when logging to H2 session vsl #4095

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Consistent locking when logging to H2 session vsl #4095

wants to merge 4 commits into from

Commits on Jul 18, 2024

  1. H2: Add utility function to do proper logging to the h2 sess vsl 

    Logging to the h2 sess vsl is incosistent. It is sometimes done
while holding the h2 session mutex, and somtimes without it. This
utility function makes sure we take the lock when necessary (when
more than 1 stream have been created).
    @walid-git
    walid-git committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3fb3c45 View commit details
    Browse the repository at this point in the history

  2. H2: Release the H2 sess lock before calling h2h_decode_fini() 

    We already call it in 3 other places without holding the lock,
this will make it easier to handle locking inside h2h_decode_fini
itself.
    @walid-git
    walid-git committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ae6e4a4 View commit details
    Browse the repository at this point in the history

  3. H2: Use H2S_Lock_VSLb() when logging to the sess vsl

    @walid-git
    walid-git committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6809ec5 View commit details
    Browse the repository at this point in the history

  4. SQUASHME: Only take the h2 sess lock when the VSL tag is not masked

    @walid-git
    walid-git committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    42d961a View commit details
    Browse the repository at this point in the history