Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS setup #12

Conversation

zemtsov-artem
Copy link

No description provided.

@zemtsov-artem
Copy link
Author

@vasily-v-ryabov could you please confirm that there are enough changes for setup.
I saw that we use dev-requirements.txt in AppVeyor.yml and landscape.yml.
Shall I update them?

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #12 into mac_os_application will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           mac_os_application      #12   +/-   ##
===================================================
  Coverage               23.82%   23.82%           
===================================================
  Files                      16       16           
  Lines                    5523     5523           
===================================================
  Hits                     1316     1316           
  Misses                   4207     4207           

setup.py Outdated Show resolved Hide resolved
@vasily-v-ryabov
Copy link
Owner

dev-requirements.txt contains all packages needed for development of pywinauto. This is not for end users. setup.py is for end user installation. There is new feature in pip to add sys.platform dependent packages into requirements file. Ideally we can modify dev-requirements.txt this way.

@zemtsov-artem zemtsov-artem force-pushed the azemtsov/mac_os_setup branch 2 times, most recently from ebbeeca to cb8b6fe Compare February 15, 2020 18:31
@zemtsov-artem
Copy link
Author

dev-requirements.txt contains all packages needed for development of pywinauto. This is not for end users. setup.py is for end user installation. There is new feature in pip to add sys.platform dependent packages into requirements file. Ideally we can modify dev-requirements.txt this way.

Applied

dev-requirements.txt Outdated Show resolved Hide resolved
dev-requirements.txt Show resolved Hide resolved
dev-requirements.txt Outdated Show resolved Hide resolved
@vasily-v-ryabov vasily-v-ryabov merged commit 0b0be67 into vasily-v-ryabov:mac_os_application Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants