fix(xo-web/pool/advanced): handle undefined default SR (#7616)

Introduced by #7451
vatesfr · Apr 30, 2024 · 2e9c1d7 · 2e9c1d7
1 parent 3a68a61
commit 2e9c1d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -25,6 +25,7 @@
 - [XOSTOR/create] In the summary section, the warning message "Hosts do not have the same number of disks" now takes into consideration host without disks (PR [#7572](https://github.com/vatesfr/xen-orchestra/pull/7572))
 - [XOSTOR] Install or update packages on all hosts in the pool rather than just hosts with disks (PR [#7597](https://github.com/vatesfr/xen-orchestra/pull/7597))
 - [XOSTOR] Fix `LVM_ERROR(5)` during XOSTOR creation (PR [#7598](https://github.com/vatesfr/xen-orchestra/pull/7598))
+- [Pool/Advanced] Fix `an error has occurred` when no default SR is set on the pool (PR [#7616](https://github.com/vatesfr/xen-orchestra/pull/7616))
 
 ### Packages to release
 

diff --git a/packages/xo-web/src/xo-app/pool/tab-advanced.js b/packages/xo-web/src/xo-app/pool/tab-advanced.js
@@ -204,8 +204,8 @@ class SelectDefaultSr extends Component {
     const { defaultSr } = this.props
 
     return (
-      <XoSelect onChange={setDefaultSr} value={defaultSr.id} xoType='SR'>
-        <Sr id={defaultSr.id} />
+      <XoSelect onChange={setDefaultSr} value={defaultSr} xoType='SR'>
+        {defaultSr !== undefined ? <Sr id={defaultSr.id} /> : _('noValue')}
       </XoSelect>
     )
   }