Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web): edit default SR in pool advanced tab #7451

Merged
merged 6 commits into from
Mar 21, 2024
Merged

feat(xo-web): edit default SR in pool advanced tab #7451

merged 6 commits into from
Mar 21, 2024

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Mar 7, 2024 •
edited

Description

Add default SR configuration in pool advanced tab.
Fixes #7414

Capture d’écran du 2024-03-07 15-07-59

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet b-Nollet force-pushed the default-SR-pool-advanced branch 2 times, most recently from 6f09908 to 775833d Compare March 7, 2024 14:34
@b-Nollet b-Nollet requested a review from julien-f March 7, 2024 14:58
julien-f
julien-f reviewed Mar 8, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f requested a review from MathieuRA March 8, 2024 09:42
MathieuRA
MathieuRA requested changes Mar 11, 2024
View reviewed changes
CHANGELOG.unreleased.md Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias March 11, 2024 14:08
@b-Nollet b-Nollet requested a review from MathieuRA March 11, 2024 15:26
@MathieuRA MathieuRA removed their request for review March 11, 2024 15:45
pdonias
pdonias requested changes Mar 14, 2024
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@b-Nollet b-Nollet requested a review from pdonias March 14, 2024 13:58
@b-Nollet b-Nollet requested a review from pdonias March 21, 2024 08:49
@pdonias pdonias requested a review from MathieuRA March 21, 2024 10:25
@MathieuRA MathieuRA requested a review from julien-f March 21, 2024 15:06
@julien-f julien-f merged commit 1b5157e into master Mar 21, 2024
1 check passed
@julien-f julien-f deleted the default-SR-pool-advanced branch March 21, 2024 15:30
pdonias added a commit that referenced this pull request Apr 30, 2024
@pdonias
fix(xo-web/pool/advanced): handle undefined default SR
e87705b 
Introduced by #7451
@pdonias pdonias mentioned this pull request Apr 30, 2024
Merged
MathieuRA pushed a commit that referenced this pull request Apr 30, 2024
@pdonias
fix(xo-web/pool/advanced): handle undefined default SR (#7616)
2e9c1d7 
Introduced by #7451
pdonias added a commit that referenced this pull request May 2, 2024
@pdonias
fix(xo-web/pool): only show pool SRs in default SR selector
9a46b9a 
Introduced by #7451
@pdonias pdonias mentioned this pull request May 2, 2024
Merged
pdonias added a commit that referenced this pull request May 6, 2024
@pdonias
fix(xo-web/pool): only show pool SRs in default SR selector (#7626)
e3d718f 
Introduced by #7451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate choise of "default SR" to pool settings
4 participants
@b-Nollet @julien-f @pdonias @MathieuRA