Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item components #2605

Closed
julien-f opened this issue Jan 31, 2018 · 2 comments
Closed

Item components #2605

julien-f opened this issue Jan 31, 2018 · 2 comments

Comments

@julien-f
Copy link
Member

static propTypes = {
  icon: PropTypes.bool,
  id: PropTypes.string.isRequired,
  icon: PropTypes.bool,
}

static defaultProps = {
  icon: true,
  link: false,
}

<VmItem id='5bwjbscqn3v' icon={false} link />
<ResourceSetItem id='5bwjbscqn3v' icon={false} link />
@julien-f julien-f modified the milestones: 5.24, 5.23 Jul 10, 2018
badrAZ added a commit that referenced this issue Jul 24, 2018
badrAZ added a commit that referenced this issue Jul 25, 2018
@pdonias pdonias modified the milestones: [Frozen] 5.23, 5.25 Jul 26, 2018
Rajaa-BARHTAOUI added a commit to Rajaa-BARHTAOUI/xo-web that referenced this issue Aug 8, 2018
Rajaa-BARHTAOUI added a commit to Rajaa-BARHTAOUI/xo-web that referenced this issue Aug 13, 2018
Rajaa-BARHTAOUI added a commit to Rajaa-BARHTAOUI/xo-web that referenced this issue Aug 13, 2018
Rajaa-BARHTAOUI added a commit to Rajaa-BARHTAOUI/xo-web that referenced this issue Aug 14, 2018
@julien-f
Copy link
Member Author

Related to #3021

@julien-f julien-f assigned Rajaa-BARHTAOUI and unassigned badrAZ Aug 22, 2018
@julien-f julien-f modified the milestones: [Frozen] 5.25, 5.26, 5.28 Aug 22, 2018
@julien-f julien-f modified the milestones: 5.28, 5.29 Sep 20, 2018
@julien-f julien-f modified the milestones: 5.29, 5.30 Oct 4, 2018
@julien-f julien-f modified the milestones: [Frozen] 18.14, 18.15 Nov 16, 2018
@pdonias
Copy link
Member

pdonias commented Dec 12, 2018

Won't add the support for icon={false} until we actually need it.

@pdonias pdonias closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants