feat(xo-web/render-xo-item): simpler item components #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
force-pushed
the
pierre-render-xo-item
branch
from
cc640b0
to
abbc976
Compare
| object: PropTypes.object.isRequired, | ||
| return ( | ||
| <span> | ||
| <Icon icon='network' /> {network.name_label} |
There was a problem hiding this comment.
why u delete this:
{pool && `(${pool.name_label || pool.id})`}There was a problem hiding this comment.
It's in the pool component.
| return ( | ||
| <span> | ||
| <Icon icon='disk' /> {vdi.name_label} | ||
| {vdi.name_description && <span> ({vdi.name_description})</span>} |
There was a problem hiding this comment.
why you didn't display the SR instead description?
There was a problem hiding this comment.
I kept it as it was. I'm not trying to change the behaviour in this PR.
pdonias
force-pushed
the
pierre-render-xo-item
branch
3 times, most recently
from
0b3662a
to
77d9882
Compare
pdonias
force-pushed
the
pierre-render-xo-item
branch
from
77d9882
to
15b930b
Compare
Rajaa-BARHTAOUI
approved these changes
Nov 19, 2018
pdonias
force-pushed
the
pierre-render-xo-item
branch
from
b021910
to
2a45815
Compare
pdonias
force-pushed
the
pierre-render-xo-item
branch
from
2a45815
to
c8ea6d1
Compare
pdonias
changed the title
badrAZ
suggested changes
Dec 3, 2018
| ]) | ||
|
|
||
| SrItem.propTypes = XO_ITEM_PROP_TYPES | ||
| VmTemplate.propTypes = { | ||
| id: PropTypes.string.isRequired, |
| ]) | ||
|
|
||
| SrItem.propTypes = XO_ITEM_PROP_TYPES | ||
| VmTemplate.propTypes = { | ||
| id: PropTypes.string.isRequired, |
| const getHost = createGetObject() | ||
| return { | ||
| host: getHost, | ||
| pool: createGetObject(createSelector(getHost, host => host.$pool)), |
| // =================================================================== | ||
|
|
||
| export const Sr = decorate([ | ||
| connectStore(() => { |
There was a problem hiding this comment.
connectStore(() => {
const getSr = (state, props) => createGetObject()(state, props, props.self)
return {
sr: getSr,
container: createGetObject(
createSelector(
getSr,
(sr = {}) => sr.$container
)
),
}
})There was a problem hiding this comment.
(state, props) => createGetObject()(state, props, props.self) would create a new selector (thus invalidate the cache) on each call.
| RemoteItem.propTypes = XO_ITEM_PROP_TYPES | ||
| Sr.propTypes = { | ||
| id: PropTypes.string.isRequired, | ||
| link: PropTypes.bool, |
| const getObject = createGetObject() | ||
| // FIXME: props.self ugly workaround to get object as a self user | ||
| return (state, props) => ({ | ||
| vdi: getObject(state, props, props.self), |
There was a problem hiding this comment.
You mean inline getObject? We want to use the same selector for all the component's lifetime.
There was a problem hiding this comment.
My bad, you're right, we don't want create a function on each call.
| return (state, props) => ({ | ||
| // true to bypass permissions as a self user | ||
| sr: getSr(state, props, true), | ||
| network: getObject(state, props, props.self), |
badrAZ
approved these changes
Dec 3, 2018
| const getObject = createGetObject() | ||
| // FIXME: props.self ugly workaround to get object as a self user | ||
| return (state, props) => ({ | ||
| vdi: getObject(state, props, props.self), |
There was a problem hiding this comment.
My bad, you're right, we don't want create a function on each call.
This was referenced Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2605
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged