Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some forms not displayed for PVHVM guests #3576

Closed
olivierlambert opened this issue Oct 22, 2018 · 1 comment
Closed

Some forms not displayed for PVHVM guests #3576

olivierlambert opened this issue Oct 22, 2018 · 1 comment
Assignees
@Enishowk
Labels
severity 3: high type: bug 🐛
Milestone
18.14

Comments

@olivierlambert
Copy link
Member

Example with VGA and video RAM, that should be in Advanced section, just before VM limits:

https://github.com/vatesfr/xen-orchestra/blob/master/packages/xo-web/src/xo-app/vm/tab-advanced.js#L532

But I can't see it for PVHVM guests. I suppose there is a lot of tests where we originally checked hvm, and forgot to update for pvhvm.

Please do a search to find all those cases. FYI, pvhvm == hvm in terms of behavior.
@julien-f julien-f added this to the 18.15 milestone Nov 6, 2018
Enishowk added a commit that referenced this issue Nov 8, 2018
@Enishowk
feat(xo-web): add VGA and video RAM display in advanced tab for pvhvm
c89c6d9 
Fixes #3576
@Enishowk Enishowk mentioned this issue Nov 8, 2018
Merged
4 tasks
Enishowk added a commit that referenced this issue Nov 8, 2018
@Enishowk
feat(xo-web): add VGA and video RAM display in advanced tab for pvhvm
95280f4 
Fixes #3576
Enishowk added a commit that referenced this issue Nov 8, 2018
@Enishowk
feat(xo-web): add VGA and video RAM display in advanced tab for pvhvm
d397c12 
Fixes #3576
Enishowk added a commit that referenced this issue Nov 8, 2018
@Enishowk
feat(xo-web): add VGA and video RAM display in advanced tab for pvhvm
7797319 
Fixes #3576
@julien-f
Copy link
Member

julien-f commented Nov 8, 2018

Fixed by 00e1601

@julien-f julien-f closed this as completed Nov 8, 2018
julien-f pushed a commit that referenced this issue Nov 8, 2018
@Enishowk @julien-f
fix(xo-web/vm): restore display of pvhvm virtualization mode (#3662)
673475d 
Fixes #3576
Rajaa-BARHTAOUI pushed a commit to Rajaa-BARHTAOUI/xo-web that referenced this issue Nov 9, 2018
@Enishowk @Rajaa-BARHTAOUI
fix(xo-web/vm): restore display of pvhvm virtualization mode (vatesfr…
4ff64ef 
…#3662)

Fixes vatesfr#3576
@julien-f julien-f modified the milestones: 18.15, [Frozen] 18.14 Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enishowk Enishowk

Labels
severity 3: high type: bug 🐛
Projects
None yet
Milestone
18.14
Development

No branches or pull requests
3 participants
@julien-f @olivierlambert @Enishowk