Netbox plugin: vm duplicates at plugin sync

[TristisOris]

Describe the bug
items with same UID duplicated.

To Reproduce

1. have 2 pools. 1st pool was disabled\unavailable for sync, and all VM migrated to 2nd.
2. after syncing all VM appear at NB second time on 2nd pool.

Expected behavior
move VM from 1st pool to 2nd based on unique VM ID.

Screenshots

Desktop (please complete the following information):

• Node: [e.g. 16.12.1]
• xo-server 5.84.1
• xo-web 5.90.0
• hypervisor: XCP-ng 8.2.0

Additional context
NetBox version 3.0.11

[pdonias]

Hi, I'm not sure this is something that we should do because:

• if the 1st pool is supposed to come back to life soon, then it will be synchronized and the old VMs will be removed from Netbox
• if the pool has been permanently deleted/disconnected, then you should manually delete the cluster from Netbox

We're also trying to avoid deleting things from a pool that isn't reachable in case you need to retrieve some information about that pool using Netbox.

[TristisOris]

well, we have vm's UUID, so 99% we know that they now exist on another pool, no matter why. And if transfer already happens, problem only to confirm it and move data, instead create a clone.
No need to remove pool or another core objects, but VM migration its a usual action.

pool can be disabled for a weeks, if h\w replacement required.

[pdonias]

VM migration is a usual action indeed, but removing an entire pool isn't. And the behavior you described only happens if you remove/disconnect a pool. If the 2 pools are still there, the old VMs will be removed from Netbox. You can also manually trigger a Netbox synchronization right before disabling the pool to remove the VMs from Netbox.