Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server-netbox): rewrite #6950

Merged
merged 13 commits into from Jul 27, 2023
Merged

feat(xo-server-netbox): rewrite #6950

merged 13 commits into from Jul 27, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jul 25, 2023

Fixes #6038, Fixes #6135, Fixes #6024, Fixes #6036
See https://xcp-ng.org/forum/topic/6070
See xoa-support#5695
See https://xcp-ng.org/forum/topic/6149
See https://xcp-ng.org/forum/topic/6332

Screenshots

Capture_2023-07-27_15:52:52
Capture_2023-07-27_15:50:09

Description

Complete rewrite of the plugin. Main functional changes:

  • Synchronize VM description
  • Fix duplicated VMs in Netbox after disconnecting one pool
  • Migrating a VM from one pool to another keeps VM data added manually
  • Fix largest IP prefix being picked instead of smallest
  • Fix synchronization not working if some pools are unavailable
  • Better error messages

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias requested a review from julien-f July 27, 2023 07:44
@pdonias pdonias marked this pull request as ready for review July 27, 2023 07:44
@julien-f julien-f merged commit 3b1bcc6 into master Jul 27, 2023
1 check passed
@julien-f julien-f deleted the pierre-netbox-pool-migration branch July 27, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants