S3 Remotes Broken (Disabled)

[andrew64k]

XO Source commit 4784bbf (current master)

Describe the bug
S3 Backup remotes are forced to disabled.
Was/Is working on XO Source commit bee0eb9

To Reproduce
Steps to reproduce the behavior:
After update, See existing S3 remote disabled, try to enable it, get error:

remote.test
{
  "id": "9890e0c4-ba3a-4810-8245-a49fdf16b16e"
}
{
  "message": "remote is disabled",
  "name": "Error",
  "stack": "Error: remote is disabled
    at _class2.getRemoteWithCredentials (file:///opt/xo/xo-builds/xen-orchestra-202312181617/packages/xo-server/src/xo-mixins/remotes.mjs:191:13)
    at _class2.testRemote (file:///opt/xo/xo-builds/xen-orchestra-202312181617/packages/xo-server/src/xo-mixins/remotes.mjs:105:20)
    at Api.#callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202312181617/packages/xo-server/src/xo-mixins/api.mjs:445:20)"
}

Goto settings: Remotes:
All S3 remotes disabled, can not enabled.

Expected behavior
Expected to be enabled so backups work.

Environment (please provide the following information):

Node 18.19, debian 11 or 12.... works again when XO is reverted to older version

[andrew64k]

Fixed. Thanks.

[andrew64k]

Now that the remote can be enabled and a backup runs, the restore list is empty.

[andrew64k]

I do see an error:

Dec 19 13:07:33 xo2 xo-server[109910]: 2023-12-19T18:05:42.578Z xo:xo-mixins:backups-ng WARN listVmBackups for remote 9890e0c4-ba3a-4810-8245-a49fdf16b16e: {
Dec 19 13:07:33 xo2 xo-server[109910]:   error: TypeError: Cannot convert undefined or null to object
Dec 19 13:07:33 xo2 xo-server[109910]:       at Function.values (<anonymous>)
Dec 19 13:07:33 xo2 xo-server[109910]:       at formatVmBackup (file:///opt/xo/xo-builds/xen-orchestra-202312191146/@xen-orchestra/backups/formatVmBackups.mjs:28:30)
Dec 19 13:07:33 xo2 xo-server[109910]:       at Array.map (<anonymous>)
Dec 19 13:07:33 xo2 xo-server[109910]:       at file:///opt/xo/xo-builds/xen-orchestra-202312191146/@xen-orchestra/backups/formatVmBackups.mjs:35:52
Dec 19 13:07:33 xo2 xo-server[109910]:       at /opt/xo/xo-builds/xen-orchestra-202312191146/node_modules/lodash/mapValues.js:38:34
Dec 19 13:07:33 xo2 xo-server[109910]:       at /opt/xo/xo-builds/xen-orchestra-202312191146/node_modules/lodash/_createBaseFor.js:17:11
Dec 19 13:07:33 xo2 xo-server[109910]:       at baseForOwn (/opt/xo/xo-builds/xen-orchestra-202312191146/node_modules/lodash/_baseForOwn.js:13:20)
Dec 19 13:07:33 xo2 xo-server[109910]:       at mapValues (/opt/xo/xo-builds/xen-orchestra-202312191146/node_modules/lodash/mapValues.js:37:3)
Dec 19 13:07:33 xo2 xo-server[109910]:       at formatVmBackups (file:///opt/xo/xo-builds/xen-orchestra-202312191146/@xen-orchestra/backups/formatVmBackups.mjs:35:10)
Dec 19 13:07:33 xo2 xo-server[109910]:       at Function.<anonymous> (file:///opt/xo/xo-builds/xen-orchestra-202312191146/packages/xo-server/src/xo-mixins/backups-ng/index.mjs:587:11)
Dec 19 13:07:33 xo2 xo-server[109910]: }
Dec 19 13:07:33 xo2 xo-server[109910]: 2023-12-19T18:07:33.588Z xo:xo-mixins:backups-ng WARN listVmBackups for remote ac27c736-d5da-41b0-8cb7-32e8719958ef: {
Dec 19 13:07:33 xo2 xo-server[109910]:   error: Error: remote is disabled
Dec 19 13:07:33 xo2 xo-server[109910]:       at _class2.getRemoteWithCredentials (file:///opt/xo/xo-builds/xen-orchestra-202312191146/packages/xo-server/src/xo-mixins/remotes.mjs:191:13)
Dec 19 13:07:33 xo2 xo-server[109910]:       at BackupNg._listVmBackupsOnRemote (file:///opt/xo/xo-builds/xen-orchestra-202312191146/packages/xo-server/src/xo-mixins/backups-ng/index.mjs:573:22)
Dec 19 13:07:33 xo2 xo-server[109910]: }