feat(new-vm): show resource set limits #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
requested changes
Sep 21, 2016
| @@ -225,6 +225,38 @@ $select-input-height: 40px; // Bootstrap input height | |||
| opacity: 0.6; | |||
| } | |||
|
|
|||
| // LIMITS STYLE ================================================================ | |||
There was a problem hiding this comment.
Move usage and limits in their own CSS file and import it.
| @@ -143,27 +146,19 @@ export default class NewVm extends BaseComponent { | |||
| this.state = { state: {} } | |||
| } | |||
|
|
|||
| componentDidMount () { | |||
| componentWillMount () { | |||
| } | ||
| _getResolvedResourceSet = createSelector( | ||
| this._getResourceSet, | ||
| resourceSet => resolveResourceSet(resourceSet) |
| @@ -314,7 +307,9 @@ export default class NewVm extends BaseComponent { | |||
|
|
|||
| const storeState = store.getState() | |||
| const _isInResourceSet = this._getIsInResourceSet() | |||
| return ( | ||
| CPUs <= availableCpus && | ||
| memory <= availableMemory && | ||
| sumBy(VDIs, 'size') <= availableDisk |
There was a problem hiding this comment.
You should handle when some limits are not defined.
pdonias
force-pushed
the
pierre-new-vm-self-service-quotas
branch
from
df15f4f
to
fa32f5f
Compare
olivierlambert
approved these changes
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1541