Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(xo-web/backup-ng): timeout is in hours #3553

Merged
merged 3 commits into from
Oct 17, 2018
Merged

Conversation

Enishowk
Copy link
Contributor

@Enishowk Enishowk commented Oct 17, 2018

Fixes #3550

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

Screenshot

screenshot 2018-10-17 at 19 01 56

@julien-f
Copy link
Member

Please add a small screenshot to the UI change 🙂

@Enishowk
Copy link
Contributor Author

Please add a small screenshot to the UI change 🙂

And it's done. ;)

@julien-f julien-f merged commit aa5b3dc into master Oct 17, 2018
@julien-f julien-f deleted the chore-timeout-backupng branch October 17, 2018 17:24
@julien-f
Copy link
Member

There is an issue in PR, the UI indeed marks the timeout as being in hours but it's still in seconds, we need to correctly transform the value as well.

I'm creating a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backup NG] Timeout should be hours
2 participants