feat(xo-server/backup-ng): emit a warning instead of a ghost VM task #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
reviewed
Nov 6, 2018
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
| ### Enhancements | |||
|
|
|||
| - [VM] Ability to set nested virtualization in settings [#3619](https://github.com/vatesfr/xen-orchestra/issues/3619) (PR [#3625](https://github.com/vatesfr/xen-orchestra/pull/3625)) | |||
| - [Backup NG logs] Display warning in case of missing VMs instead of a ghosts VMs tasks (PR [#3647](https://github.com/vatesfr/xen-orchestra/pull/3647)) | |||
There was a problem hiding this comment.
Move this entry to the next release please.
julien-f
reviewed
Nov 6, 2018
badrAZ
force-pushed
the
deletedVmsInfo
branch
from
2397d89
to
069c973
Compare
julien-f
reviewed
Nov 7, 2018
| } | ||
| }) | ||
|
|
||
| if (missingVms.length !== 0) { | ||
| logger.notice('skippedVms', { |
There was a problem hiding this comment.
logger.warning would be more logical.
julien-f
reviewed
Nov 7, 2018
| @@ -475,6 +475,7 @@ const extractIdsFromSimplePattern = (pattern: mixed) => { | |||
| // | |||
| // job.start(data: { mode: Mode, reportWhen: ReportWhen }) | |||
| // ├─ task.info(message: 'vms', data: { vms: string[] }) | |||
| // ├─ task.warning(message: 'skippedVms', data: { vms: string[] }) | |||
badrAZ
force-pushed
the
deletedVmsInfo
branch
from
069c973
to
74ec813
Compare
julien-f
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged