feat(xo-web): add pool name to templates #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
requested changes
Jan 23, 2019
| if (template === undefined) { | ||
| return unknowItem(id, 'template') | ||
| } | ||
|
|
||
| return ( | ||
| <span> | ||
| <Icon icon='vm' /> {template.name_label} | ||
| {!self && pool !== undefined && ( | ||
| <span className={'text-muted'}>{` - ${pool.name_label}`}</span> |
| if (template === undefined) { | ||
| return unknowItem(id, 'template') | ||
| } | ||
|
|
||
| return ( | ||
| <span> | ||
| <Icon icon='vm' /> {template.name_label} | ||
| {!self && pool !== undefined && ( |
There was a problem hiding this comment.
You don't need the !self condition as pool will be undefined for self users anyway.
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| - [Plugins] New field to filter displayed plugins (PR [#3832](https://github.com/vatesfr/xen-orchestra/pull/3871)) | |||
| - Ability to copy ID of "unknown item"s [#3833](https://github.com/vatesfr/xen-orchestra/issues/3833) (PR [#3856](https://github.com/vatesfr/xen-orchestra/pull/3856)) | |||
| - [Cloud-Init] switch config drive type to `nocloud` to prepare for the passing of network config (PR [#3877](https://github.com/vatesfr/xen-orchestra/pull/3877)) | |||
| - Add pool name to templates [#3894](https://github.com/vatesfr/xen-orchestra/issues/3894) (PR [#3896](https://github.com/vatesfr/xen-orchestra/pull/3896)) | |||
There was a problem hiding this comment.
Reading this without having worked on it would probably be confusing.
"[UI] Show pool name next to templates' names"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3894
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be mergedScreenshots