feat(xo-web/home): set description on bulk snapshot #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
requested changes
Feb 4, 2019
packages/xo-server/src/api/vm.js
Outdated
| @@ -773,6 +778,7 @@ export const snapshot = defer(async function( | |||
| snapshot.params = { | |||
| id: { type: 'string' }, | |||
| name: { type: 'string', optional: true }, | |||
| description: { type: 'string', optional: true }, | |||
| return { | ||
| names: mapValues(this.props.vms, generateName), | ||
| names, | ||
| descriptions, | ||
| saveMemory, | ||
| } | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <div> |
|
|
||
| const names = [] | ||
| const descriptions = [] | ||
| forEach(this.props.vms, ({ id, ...vm }) => { |
Rajaa-BARHTAOUI
force-pushed
the
descption-bulk-snapshot
branch
2 times, most recently
from
418f5eb
to
4dbfa46
Compare
pdonias
requested changes
Feb 4, 2019
| } | ||
|
|
||
| const generateName = buildTemplate(namePattern, { | ||
| const RULES = { |
| }) | ||
|
|
||
| return { | ||
| names: mapValues(this.props.vms, generateName), | ||
| names: namePattern !== '' ? names : {}, | ||
| descriptions: descriptionPattern !== '' ? descriptions : {}, |
There was a problem hiding this comment.
Is this the behaviour we want? If the user explicitly removes the default text from the input and leaves it empty, doesn't it mean that he wants the snapshots' descriptions to be empty?
There was a problem hiding this comment.
The description will be the description of the VM, if the user removes the default text.
| const descriptions = [] | ||
| forEach(this.props.vms, (vm, id) => { | ||
| names[id] = generateName(vm) | ||
| descriptions[id] = generateDescription(vm) |
There was a problem hiding this comment.
It would be nice to not run this when we'll eventually return {} anyway.
Rajaa-BARHTAOUI
force-pushed
the
descption-bulk-snapshot
branch
from
bd3da7f
to
d6edd5e
Compare
pdonias
approved these changes
Feb 6, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3925
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be mergedScreenshots