Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/backup-ng): ability to set the full backup interval #4083

Merged
merged 4 commits into from
Mar 29, 2019
Merged

feat(xo-web/backup-ng): ability to set the full backup interval #4083

merged 4 commits into from
Mar 29, 2019

Conversation

badrAZ
Copy link
Contributor

@badrAZ badrAZ commented Mar 27, 2019 •
edited by pdonias
Loading

Fixes #1783

Screenshots

image

image

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

@badrAZ badrAZ requested review from pdonias and julien-f March 27, 2019 13:50
@badrAZ badrAZ self-assigned this Mar 27, 2019
@julien-f julien-f removed their request for review March 27, 2019 14:52
@pdonias
Copy link
Member

pdonias commented Mar 28, 2019

Requires #4086, right?

@julien-f
Copy link
Member

Yes, maybe we should rebase this one on top the other to help testing, do you want me to do it?

@badrAZ badrAZ changed the base branch from master to server-keyDeltaBackup March 28, 2019 13:19
@badrAZ badrAZ force-pushed the keyMetadataBackup-UI branch 2 times, most recently from 6b49dc8 to e69148c Compare March 28, 2019 13:24
@pdonias
Copy link
Member

pdonias commented Mar 28, 2019

If it helps the server-side review, yes. Otherwise, I can wait for #4086 to be merged to test and merge this PR.

@julien-f
Copy link
Member

Done, I think it's a good idea.

@julien-f julien-f force-pushed the keyMetadataBackup-UI branch 4 times, most recently from 24fe5b1 to 5fcbba3 Compare March 28, 2019 14:55
@julien-f
Copy link
Member

Please rebase on server-keyDeltaBackup and make sure the CHANGELOG is ok.

pdonias pushed a commit that referenced this pull request Mar 28, 2019
@julien-f @pdonias
feat(xo-server/backup): fullInterval setting (#4086)
1dfb50f 
See #4083
pdonias
pdonias requested changes Mar 29, 2019
View reviewed changes
CHANGELOG.unreleased.md Show resolved Hide resolved
@pdonias pdonias merged commit 137f7ba into server-keyDeltaBackup Mar 29, 2019
@pdonias pdonias deleted the keyMetadataBackup-UI branch March 29, 2019 10:20
julien-f pushed a commit that referenced this pull request Mar 29, 2019
@badrAZ @julien-f
feat(xo-web/backup-ng): ability to set the full backup interval (#4083)
5aa3344 
Fixes #1783
@MathieuRA MathieuRA mentioned this pull request Jan 27, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

Assignees

@badrAZ badrAZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badrAZ @pdonias @julien-f