Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/scheduling): start/stop schedules after import #4624

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Oct 24, 2019

Check list

Check if done.

Strikethrough if not relevant: example (doc).

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42) (none)
  • if UI changes, a screenshot has been added to the PR (lowlevel stuff)
  • documentation updated (lowlevel stuff)
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)
    • unit tests (e.g. cron/parse.spec.js)
    • if xo-server API changes, the corresponding test has been added to/updated on xo-server-test (too difficult to test)
    • at least manual testing

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f merged commit 21faaeb into master Oct 25, 2019
@julien-f julien-f deleted the server-start-schedule-after-import branch October 25, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants