feat(xo-web/home): allow to change the number of items per page #4708

Rajaa-BARHTAOUI · 2019-12-16T15:48:34Z

See #4535

Screenshots

Check list

Check if done, if not relevant leave unchecked.

PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
if UI changes, a screenshot has been added to the PR
documentation updated
CHANGELOG.unreleased.md:
- enhancement/bug fix entry added
- list of packages to release updated (${name} v${new version})
I have tested added/updated features (and impacted code)
- unit tests (e.g. cron/parse.spec.js)
- if xo-server API changes, the corresponding test has been added to/updated on xo-server-test
- at least manual testing

Process

create a PR as soon as possible
mark it as WiP: (Work in Progress) if not ready to be merged
when you want a review, add a reviewer (and only one)
if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

Be impeccable with your word.
Don't take anything personally.
Don't make assumptions.
Always do your best.

julien-f · 2019-12-17T14:32:10Z

packages/xo-web/src/xo-app/home/index.js

+      pathname,
+      query: { ...query, n: nItems },
+    })
+  }


I think it would be interesting to save this in cookies.

packages/xo-web/src/xo-app/home/index.js

CHANGELOG.unreleased.md

pdonias · 2020-01-07T08:56:03Z

packages/xo-web/src/xo-app/home/index.js

@@ -5,6 +5,7 @@ import ActionButton from 'action-button'
 import Button from 'button'
 import CenterPanel from 'center-panel'
 import classNames from 'classnames'
+import cookies from 'cookies-js'


Is it sorted?

That's weird because if it's case sensitive, then CenterPanel and Component should be grouped and if it isn't, then cookies should be after Component.

It's my fault. it's not sorted.
To avoid unrelated changes, I will import it after Component.

packages/xo-web/src/xo-app/home/index.js

CHANGELOG.unreleased.md

pdonias · 2020-01-21T09:26:23Z

packages/xo-web/src/xo-app/home/index.js

@@ -5,6 +5,7 @@ import ActionButton from 'action-button'
 import Button from 'button'
 import CenterPanel from 'center-panel'
 import classNames from 'classnames'
+import cookies from 'cookies-js'


That's weird because if it's case sensitive, then CenterPanel and Component should be grouped and if it isn't, then cookies should be after Component.

packages/xo-web/src/xo-app/home/index.js

pdonias · 2020-01-21T12:42:18Z

packages/xo-web/src/xo-app/home/index.js

@@ -1154,6 +1182,7 @@ export default class Home extends Component {
      isPoolAdmin,
      noResourceSets,
    } = this.props
+    const nItemsPerPage = this._getnItemsPerPage()


pdonias · 2020-01-21T12:50:29Z

packages/xo-web/src/xo-app/home/index.js

@@ -979,7 +997,7 @@ export default class Home extends Component {
                  })}
            </span>
          </Col>
-          <Col mediumSize={8} className='text-xs-right hidden-sm-down'>
+          <Col mediumSize={6} className='text-xs-right hidden-sm-down'>


Can you check if all the sizes work fine with all the widths? If not, we can take some space from the 1st column, I think.

pdonias

Should we keep the issue open since it mentions adding a user preference for this?

pdonias · 2020-01-23T09:04:37Z

packages/xo-web/src/xo-app/home/index.js

@@ -517,6 +519,18 @@ export default class Home extends Component {
    identity,
  ])

+  _getNItemsPerPage = () =>
+    +defined(
+      this.state.homeItemsPerPage,


Why do you need to also store it in the state? Can't we only rely on the cookies?

pdonias · 2020-01-23T09:09:26Z

packages/xo-web/src/xo-app/home/index.js

@@ -683,7 +697,7 @@ export default class Home extends Component {
  _getVisibleItems = createPager(
    this._getFilteredItems,
    () => this._getPage(),
-    ITEMS_PER_PAGE
+    () => this._getNItemsPerPage()


this._getNItemsPerPage

packages/xo-web/src/xo-app/home/index.js

Rajaa-BARHTAOUI · 2020-01-27T14:12:23Z

Should we keep the issue open since it mentions adding a user preference for this?

Yes.

see #4535

Rajaa-BARHTAOUI force-pushed the rajaa-show-more-items branch 2 times, most recently from dc790c0 to c08d790 Compare December 17, 2019 14:30

julien-f reviewed Dec 17, 2019

View reviewed changes

Rajaa-BARHTAOUI force-pushed the rajaa-show-more-items branch 3 times, most recently from c2f9750 to d2e36ef Compare December 17, 2019 16:03

Rajaa-BARHTAOUI requested a review from badrAZ December 17, 2019 16:06

badrAZ suggested changes Dec 19, 2019

View reviewed changes

badrAZ requested a review from pdonias December 19, 2019 09:04

pdonias requested changes Jan 7, 2020

View reviewed changes

Rajaa-BARHTAOUI force-pushed the rajaa-show-more-items branch from 48e5bdb to f8a1c63 Compare January 20, 2020 14:23

Rajaa-BARHTAOUI requested a review from badrAZ January 20, 2020 14:42

badrAZ suggested changes Jan 20, 2020

View reviewed changes

packages/xo-web/src/xo-app/home/index.js Outdated Show resolved Hide resolved

Rajaa-BARHTAOUI force-pushed the rajaa-show-more-items branch from b12cc56 to 49a60b2 Compare January 21, 2020 08:32

Rajaa-BARHTAOUI requested a review from badrAZ January 21, 2020 08:39

badrAZ approved these changes Jan 21, 2020

View reviewed changes

badrAZ requested a review from pdonias January 21, 2020 09:04

pdonias requested changes Jan 21, 2020

View reviewed changes

Rajaa-BARHTAOUI requested a review from pdonias January 21, 2020 16:04

pdonias requested changes Jan 23, 2020

View reviewed changes

Rajaa-BARHTAOUI force-pushed the rajaa-show-more-items branch from 888b737 to a6f8e1b Compare January 23, 2020 15:40

Rajaa-BARHTAOUI requested a review from pdonias January 23, 2020 15:41

pdonias requested changes Jan 27, 2020

View reviewed changes

packages/xo-web/src/xo-app/home/index.js Outdated Show resolved Hide resolved

packages/xo-web/src/xo-app/home/index.js Outdated Show resolved Hide resolved

feat(xo-web/home): allow to change the number of items per page

0f24491

see #4535

Rajaa-BARHTAOUI force-pushed the rajaa-show-more-items branch from fcd7f25 to 0f24491 Compare January 27, 2020 14:20

Rajaa-BARHTAOUI requested a review from pdonias January 27, 2020 14:21

pdonias approved these changes Jan 27, 2020

View reviewed changes

pdonias changed the title ~~feat(xo-web/home): allow to switch the number of items per page~~ feat(xo-web/home): allow to change the number of items per page Jan 27, 2020

pdonias merged commit 70f8f96 into master Jan 27, 2020

pdonias deleted the rajaa-show-more-items branch January 27, 2020 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(xo-web/home): allow to change the number of items per page #4708

feat(xo-web/home): allow to change the number of items per page #4708

Rajaa-BARHTAOUI commented Dec 16, 2019 •

edited

Loading

julien-f Dec 17, 2019

pdonias Jan 7, 2020

Rajaa-BARHTAOUI Jan 17, 2020

pdonias Jan 21, 2020

Rajaa-BARHTAOUI Jan 21, 2020

pdonias Jan 21, 2020

pdonias Jan 21, 2020

pdonias Jan 21, 2020

pdonias left a comment

pdonias Jan 23, 2020

pdonias Jan 23, 2020

Rajaa-BARHTAOUI commented Jan 27, 2020

feat(xo-web/home): allow to change the number of items per page #4708

feat(xo-web/home): allow to change the number of items per page #4708

Conversation

Rajaa-BARHTAOUI commented Dec 16, 2019 • edited Loading

Screenshots

Check list

Process

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pdonias left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rajaa-BARHTAOUI commented Jan 27, 2020

Rajaa-BARHTAOUI commented Dec 16, 2019 •

edited

Loading