Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/licenses): rebind license to this XOA #5110

Merged
merged 2 commits into from
Jun 26, 2020

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jun 25, 2020

See xoa#55
Requires xoa#58

When an XOA license is bound to another XOA, allow the user to move it to the
current XOA (thus unbinding it from the other one).

Screenshots

Capture_2020-06-25_10:44:41
Capture_2020-06-25_10:44:58

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we display the second screenshot in an another view?

CHANGELOG.unreleased.md Show resolved Hide resolved
@pdonias
Copy link
Member Author

pdonias commented Jun 25, 2020

@Rajaa-BARHTAOUI No, it's the same screenshot but cropped for convenience.

@pdonias pdonias requested a review from badrAZ June 25, 2020 13:51
@badrAZ badrAZ self-requested a review June 25, 2020 15:25
@pdonias pdonias merged commit fe722c8 into master Jun 26, 2020
@pdonias pdonias deleted the pierre-rebind-xoa-license branch June 26, 2020 11:12
phil-flex pushed a commit to phil-flex/xen-orchestra that referenced this pull request Jun 29, 2020
See xoa#55
Requires xoa#58

When an XOA license is bound to another XOA, allow the user to move it to the
current XOA (thus unbinding it from the other one).
phil-flex pushed a commit to phil-flex/xen-orchestra that referenced this pull request Jul 13, 2020
See xoa#55
Requires xoa#58

When an XOA license is bound to another XOA, allow the user to move it to the
current XOA (thus unbinding it from the other one).
Storycrafter pushed a commit to Storycrafter/xen-orchestra that referenced this pull request Jul 23, 2020
See xoa#55
Requires xoa#58

When an XOA license is bound to another XOA, allow the user to move it to the
current XOA (thus unbinding it from the other one).
phil-flex pushed a commit to phil-flex/xen-orchestra that referenced this pull request Aug 24, 2020
See xoa#55
Requires xoa#58

When an XOA license is bound to another XOA, allow the user to move it to the
current XOA (thus unbinding it from the other one).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants