Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web): some methods call throw the 'not enough permissions' error #5303

Merged
merged 6 commits into from
Oct 13, 2020

Conversation

Rajaa-BARHTAOUI
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI commented Oct 1, 2020

See #5285

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@badrAZ badrAZ requested a review from pdonias October 1, 2020 14:00
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Rajaa-BARHTAOUI and others added 2 commits October 6, 2020 09:45
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
@badrAZ badrAZ requested a review from pdonias October 8, 2020 14:56
@pdonias pdonias merged commit 313eb13 into master Oct 13, 2020
@pdonias pdonias deleted the rajaa-fixEnoughPermissions branch October 13, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants