feat(xo-web/SortedTable): allow to change the number of items per page #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajaa-BARHTAOUI
force-pushed
the
rajaa-showSrPerPage
branch
from
40f3a86
to
77a6834
Compare
badrAZ
reviewed
Nov 3, 2020
pdonias
requested changes
Nov 4, 2020
| @@ -343,6 +340,10 @@ class SortedTable extends Component { | |||
|
|
|||
| const state = (this.state = { | |||
| all: false, // whether all items are selected (accross pages) | |||
| itemsPerPage: +defined( | |||
| cookies.get('sortedTableItemsPerPage'), | |||
There was a problem hiding this comment.
Don't you think it would be better to be able to set a different value for each table? Identifying them with their stateUrlParam or another prop, maybe? I don't think someone would necessarily want the same number of items per page in the SR/disks view and in the Health view.
| @@ -53,6 +53,11 @@ import parseNdJson from './_parseNdJson' | |||
|
|
|||
| // =================================================================== | |||
|
|
|||
| export const DEFAULT_ITEMS_PER_PAGE = 20 | |||
There was a problem hiding this comment.
We should probably keep 10 as the default value, otherwise it would change for everybody.
Rajaa-BARHTAOUI
force-pushed
the
rajaa-showSrPerPage
branch
from
f543f7a
to
98123dd
Compare
Rajaa-BARHTAOUI
force-pushed
the
rajaa-showSrPerPage
branch
2 times, most recently
from
f844037
to
eb779e5
Compare
Rajaa-BARHTAOUI
force-pushed
the
rajaa-showSrPerPage
branch
from
eb779e5
to
60a7859
Compare
Rajaa-BARHTAOUI
force-pushed
the
rajaa-showSrPerPage
branch
from
61166e0
to
f997d8a
Compare
badrAZ
approved these changes
Nov 27, 2020
pdonias
requested changes
Nov 27, 2020
| @@ -306,6 +303,7 @@ class SortedTable extends Component { | |||
|
|
|||
| const state = (this.state = { | |||
| all: false, // whether all items are selected (accross pages) | |||
| itemsPerPage: +defined(cookies.get(props.location.pathname + props.stateUrlParam), DEFAULT_ITEMS_PER_PAGE), | |||
There was a problem hiding this comment.
Add a separator between the pathname and the stateUrlParam. Like -.
pdonias
approved these changes
Nov 27, 2020
pdonias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See xoa-support#3020
Check list
Fixes #007orSee xoa-support#42)CHANGELOG.unreleased.md:${name} v${new version})cron/parse.spec.js)xo-serverAPI changes, the corresponding test has been added to/updated onxo-server-testProcess
WiP:(Work in Progress) if not ready to be mergedFrom the Four Agreements: