Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): add sanity check of aliases in cleanVm #6043

Merged
merged 7 commits into from
Jan 13, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Dec 7, 2021

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@xen-orchestra/backups/_cleanVm.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/_cleanVm.js Outdated Show resolved Hide resolved
packages/vhd-lib/Vhd/VhdDirectory.js Show resolved Hide resolved
@xen-orchestra/backups/_cleanVm.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/_cleanVm.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the florent-cleanVM_check_alias branch 2 times, most recently from 58cd8b3 to 6b706cc Compare January 10, 2022 14:18
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on top of master.

Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not appear to be fully rebased, there are still some conflicts.

@julien-f julien-f merged commit 249f638 into master Jan 13, 2022
@julien-f julien-f deleted the florent-cleanVM_check_alias branch January 13, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants