-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@vates/cached-dns.lookup): small DNS cache #6196
Conversation
56f700c
to
793f026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to patch dns.lookup
directly in the module ? That way we will have a centralized point if we need to enabled / disable the caching depending on the os / node version
Do you mean, by adding a dedicated function like |
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
See https://xcp-ng.org/forum/topic/5775/dns-queries-during-backup-job
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: