Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@vates/cached-dns.lookup): small DNS cache #6196

Merged
merged 8 commits into from
Apr 22, 2022
Merged

feat(@vates/cached-dns.lookup): small DNS cache #6196

merged 8 commits into from
Apr 22, 2022

Conversation

julien-f
Copy link
Member

See https://xcp-ng.org/forum/topic/5775/dns-queries-during-backup-job

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f force-pushed the dns.lookup branch 2 times, most recently from 56f700c to 793f026 Compare April 20, 2022 21:30
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to patch dns.lookup directly in the module ? That way we will have a centralized point if we need to enabled / disable the caching depending on the os / node version

@vates/cached-dns.lookup/index.js Outdated Show resolved Hide resolved
@julien-f
Copy link
Member Author

Would it be possible to patch dns.lookup directly in the module ? That way we will have a centralized point if we need to enabled / disable the caching depending on the os / node version

Do you mean, by adding a dedicated function like createCachedLookup().patchGlobal()?

@julien-f julien-f marked this pull request as ready for review April 22, 2022 09:47
@julien-f julien-f requested a review from pdonias April 22, 2022 09:47
@vates/cached-dns.lookup/.USAGE.md Outdated Show resolved Hide resolved
@vates/cached-dns.lookup/.USAGE.md Outdated Show resolved Hide resolved
@vates/cached-dns.lookup/.USAGE.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Show resolved Hide resolved
julien-f and others added 3 commits April 22, 2022 14:44
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
@julien-f julien-f requested a review from pdonias April 22, 2022 12:47
@pdonias pdonias merged commit c9475dd into master Apr 22, 2022
@pdonias pdonias deleted the dns.lookup branch April 22, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants