Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backups): add cache for backup metadata #6220

Merged
merged 5 commits into from
May 17, 2022
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 5, 2022

Listing all the backup can be slow. To speed it up, we will cache the metadata of all the backup of each vm as gzipped json file.

The cache should be invalidated when a backup is deleted or created

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the feat_cache_listVmBackups branch 2 times, most recently from 4a66305 to 31cbcb5 Compare May 6, 2022 08:43
@fbeauchamp fbeauchamp marked this pull request as ready for review May 6, 2022 08:44
@fbeauchamp fbeauchamp requested a review from ByScripts May 6, 2022 09:07
@fbeauchamp
Copy link
Collaborator Author

tests done :

  • deleting a backup removes the cache
  • backinp up a vm deletes its cache
  • reading from the cache if it exists
  • regenerating cache if not

yarn.lock Outdated Show resolved Hide resolved
@julien-f julien-f requested a review from ByScripts May 6, 2022 14:49
@fbeauchamp fbeauchamp requested a review from julien-f May 6, 2022 14:50
@julien-f julien-f removed the request for review from ByScripts May 6, 2022 14:50
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from julien-f May 16, 2022 07:40
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from julien-f May 17, 2022 06:47
@julien-f julien-f merged commit 8bf3a74 into master May 17, 2022
@julien-f julien-f deleted the feat_cache_listVmBackups branch May 17, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants