Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/proxies): ability to bind licence to existing proxy #6348

Merged
merged 18 commits into from
Aug 31, 2022

Conversation

Rajaa-BARHTAOUI
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI commented Aug 3, 2022

zammad#7457

Screenshots

Screenshot from 2022-08-25 21-03-08

Screenshot from 2022-08-25 21-07-06

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA

This comment was marked as resolved.

@MathieuRA MathieuRA requested a review from julien-f August 9, 2022 13:54
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested review from pdonias and removed request for julien-f August 11, 2022 08:53
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the screenshot(s)

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/proxies.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/xoa/licenses/proxies.js Outdated Show resolved Hide resolved
Rajaa-BARHTAOUI and others added 3 commits August 18, 2022 13:00
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested review from MathieuRA and removed request for MathieuRA August 25, 2022 19:12
@MathieuRA MathieuRA requested a review from pdonias August 26, 2022 09:43
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/xoa/licenses/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/xoa/licenses/proxies.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
@pdonias pdonias merged commit 80cc669 into master Aug 31, 2022
@pdonias pdonias deleted the bindLicenceToProxy branch August 31, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants